This repository was archived by the owner on Jul 10, 2024. It is now read-only.
SUBMARINE-532. Use Notebook CRD & controller to spawn jupyter notebook#335
Closed
lowc1012 wants to merge 2 commits into
Closed
SUBMARINE-532. Use Notebook CRD & controller to spawn jupyter notebook#335lowc1012 wants to merge 2 commits into
lowc1012 wants to merge 2 commits into
Conversation
Contributor
|
@lowc1012 Thanks for the contribution! One question, will the notebook controller's YAML files be added to submarine helm charts? The current script based on "kind" is for testing, right? |
Contributor
Author
|
@tangzhankun |
lowc1012
changed the title
Member
|
/cc @liuxunorg @jiwq |
aylei
reviewed
Jul 2, 2020
| # See the License for the specific language governing permissions and | ||
| # limitations under the License. | ||
| # | ||
| set -e |
Member
There was a problem hiding this comment.
good catch!
many shell scripts need to be set to set -euo pipefail.
Fix this problem in the next PR.
Contributor
Author
There was a problem hiding this comment.
@aylei Thanks for your review!
@liuxunorg Ok, I will fix other shell scripts too.
xunliu
approved these changes
Jul 2, 2020
Member
|
Will merge if no more comments. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this PR for?
This PR shows how to use Kubeflow's Notebook CRD & controller to spawn jupyter notebook
What type of PR is it?
[Improvement]
Todos
What is the Jira issue?
SUBMARINE-532
How should this be tested?
CI
Screenshots (if appropriate)
Questions: